Changed TargetOnKart.wrap_with_lock to TargetOnKart.wrap_with_run_lock #332
+13
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mski-iksm
commented
Nov 9, 2023
| @@ -253,7 +253,7 @@ def test_no_redis(self): | |||
| redis_port=None, | |||
| ) | |||
| mock_func = MagicMock() | |||
| resulted = wrap_with_run_lock(func=mock_func, redis_params=redis_params)(123, b='abc') | |||
| resulted = wrap_with_load_lock(func=mock_func, redis_params=redis_params)(123, b='abc') | |||
There was a problem hiding this comment.
TestWrapWithLoadLock was suppose to test wrap_with_load_lock(), but accidentally tested wrap_with_run_lock() in mistake.
mski-iksm
force-pushed
the
fix/fix_wrap_with_run_lock_name
branch
from
d587d89 to
0924d54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method was calling
wrap_with_run_lock(), so I think TargetOnKart.wrap_with_run_lock is more accurate name.